UI Base: Account for upgrade path meaning no defaults set for new properties #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Under the covers with the Plugin work we introduced two new properties to
ui-base, but nether of them have editable configuration at the NR Editor level - as such, when upgrading versions of Dashboard 2.0, these properties do not get set, and are then undefined when running Dashboard.This PR sets defaults for those properties if they do not exist at the point of deploy/restart of Node-RED. This path will only occur for those upgrading from < 0.11.0 to 0.11.0, and using an already created
ui-base.First noticed/raised here: https://discourse.nodered.org/t/dashboard-2-beta-development/83550/122?u=joepavitt
Checklist