Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Steps to reproduce:
Hide a group in the sidebar (via the eye button), then the text will automatically become strikethrough:
Edit that group (via the edit button), and press the "Done" button of the ui-page config screen.
The sidebar tree will automatically refresh, but the value of the
visible
attribute has become a string"false"
(instead of a booleanfalse
):Because the CSS class "nr-db2-sb-item-hidden" is not applied anymore, the strikethrough will be gone (although the group is still not visible).
I have fixed this by supporting string "false" similiar to how it is done for the eye-icon, because that icon is showing the correct status. And we need to keep the eye-icon status and the strikethrough of the label in sync:
Note that the real root cause is in the ui-page hml config screen, which converts the
visible
property value from a boolean to a string, but that is already reported in another issue (and I will fix that in another PR).Related Issue(s)
1296
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
area:migration
label