Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar strikethrough reset fix #1513

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

bartbutenaers
Copy link
Contributor

Description

Steps to reproduce:

  1. Hide a group in the sidebar (via the eye button), then the text will automatically become strikethrough:

    image

  2. Edit that group (via the edit button), and press the "Done" button of the ui-page config screen.

  3. The sidebar tree will automatically refresh, but the value of the visible attribute has become a string "false" (instead of a boolean false):

    image

  4. Because the CSS class "nr-db2-sb-item-hidden" is not applied anymore, the strikethrough will be gone (although the group is still not visible).

I have fixed this by supporting string "false" similiar to how it is done for the eye-icon, because that icon is showing the correct status. And we need to keep the eye-icon status and the strikethrough of the label in sync:

image

Note that the real root cause is in the ui-page hml config screen, which converts the visible property value from a boolean to a string, but that is already reported in another issue (and I will fix that in another PR).

Related Issue(s)

1296

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@joepavitt joepavitt self-requested a review December 4, 2024 15:29
@joepavitt joepavitt merged commit 4d17baa into FlowFuse:main Dec 4, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants