Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Developer Experience - Don't minify dev build #1471

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Developer Experience - Don't minify dev build #1471

merged 2 commits into from
Dec 4, 2024

Conversation

Steve-Mcl
Copy link
Contributor

@Steve-Mcl Steve-Mcl commented Nov 14, 2024 •
edited
Loading

Description

Dont minify for dev mode
Also, ditch the source maps (since its not minified!)

Discussed here: https://discourse.nodered.org/t/when-are-vuejs-methods-binded/93142/11?u=steve-mcl

@bartbutenaers
Copy link
Contributor

Thanks @Steve-Mcl !
It would also be useful to put your npm run build:dev command somewhere. I see now - for the first time - this page. Not sure whether it should but put there, because that page is not part of the contribution documentation. Even not sure why I have never found that readme page, because it contains a.o. the lint command (which I only found recently myself somewhere else).

Steve-Mcl
Steve-Mcl commented Nov 14, 2024
View reviewed changes
Copy link
Contributor Author

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update contributing docs

@Steve-Mcl Steve-Mcl requested a review from joepavitt November 15, 2024 11:44
@joepavitt joepavitt merged commit cba6e30 into main Dec 4, 2024
1 of 2 checks passed
@joepavitt joepavitt deleted the no-dev-minify branch December 4, 2024 15:19
@joepavitt joepavitt changed the title Improve DX - dont minify dev build Developer Experience - Don't minify dev build Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joepavitt joepavitt joepavitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Steve-Mcl @bartbutenaers @joepavitt