Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provided default breakpoints when there's nothing defined #1374

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Provided default breakpoints when there's nothing defined #1374

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
78a6243
Provided default breakpoints when there's nothing defined
gayanSandamal Oct 10, 2024
9b642a2
Update ui/src/mixins/responsiveness.js
gayanSandamal Oct 10, 2024
5538d08
Update ui/src/mixins/responsiveness.js
gayanSandamal Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions ui/src/mixins/responsiveness.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,23 @@ export default {
countColumns () {
let cols = 0
if (this.page) {
const b = this.page.breakpoints
// set default breakpoints if none are defined
let b = this.page.breakpoints
if (!b || !Array.isArray(b) || b.length === 0) {
b = [
{ name: 'Default', px: 0, cols: 3 },
{ name: 'Tablet', px: 576, cols: 6 },
{ name: 'Small Desktop', px: 768, cols: 9 },
{ name: 'Desktop', px: 1024, cols: 12 }
]
}
// ensure breakpoints are sorted in reverse order
const breakpoints = b.sort((a, b) => a.px - b.px)

breakpoints.forEach((bp) => {
if (window.innerWidth >= bp.px) {
cols = bp.cols
// ensure cols is a number
cols = Number(bp.cols)
}
})
}
Expand Down
Loading