Missing data after reconnect #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 29, 2024
|
Some good news. @colinl has tried this out against related issues & confirmed it |
|
In fact I meant to post that here rather than against the issue. |
joepavitt
requested changes
Oct 1, 2024
Co-authored-by: Joe Pavitt <[email protected]>
Co-authored-by: Joe Pavitt <[email protected]>
Co-authored-by: Joe Pavitt <[email protected]>
Co-authored-by: Joe Pavitt <[email protected]>
joepavitt
reviewed
Oct 4, 2024
joepavitt
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Added a single line comment just as it took me a few reads to follow, but this is great. Thanks @Steve-Mcl
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1297
Description
Watches for re-connection in the data tracker and re-sends
widget-loadupon detecting reconnection.NOTE: I found a bug in current dashboard that multiplies the handlers everytime a different page is visitied. This Pr completely refactors the event hook up so that ALL (and only the widgets associated handlers) are properly and always cleaned up.
Demo
Related Issue(s)
#1297
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel