Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout switching configuration with dynamic property support #1320

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Layout switching configuration with dynamic property support #1320

merged 3 commits into from
Oct 1, 2024

Conversation

gayanSandamal
Copy link
Contributor

@gayanSandamal gayanSandamal commented Sep 23, 2024 •
edited
Loading

Description

This feature includes,

  1. Switching between 5 different layouts row-left, row-left-swapped, row-spread, row-spread-swapped which is similar with ui-text node
  2. Dynamic property support for the newly added layout property
  3. Docs updated for the newly added property Layout and marked dynamic: true in the docs for the existing dynamic properties which haven't marked previously
  4. Necessary E2E tests are added

Related Issue(s)

#1236

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@gayanSandamal gayanSandamal linked an issue Sep 23, 2024 that may be closed by this pull request
Switch: Layout Configuration #1236
Closed
@joepavitt
Copy link
Collaborator

Ready for review @gayanSandamal?

@gayanSandamal
Copy link
Contributor Author

Ready for review @gayanSandamal?

Yes, I was waiting for tests to pass. I'm marking this as ready for review

@gayanSandamal gayanSandamal self-assigned this Sep 23, 2024
@gayanSandamal gayanSandamal marked this pull request as draft September 23, 2024 12:02
@gayanSandamal gayanSandamal marked this pull request as ready for review September 23, 2024 12:55
@gayanSandamal
Copy link
Contributor Author

The PR is updated. only the usual ❌ widgets/control.spec.js fails

@joepavitt joepavitt self-requested a review September 27, 2024 08:03
@joepavitt joepavitt merged commit d72f779 into main Oct 1, 2024
2 checks passed
@joepavitt joepavitt deleted the 1236-switch-layout-configuration branch October 1, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joepavitt joepavitt joepavitt approved these changes

Assignees

@gayanSandamal gayanSandamal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch: Layout Configuration
2 participants
@gayanSandamal @joepavitt