Layouts: Ensure we're parsing float on the "px" row height #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joepavitt
changed the title
Steve-Mcl
approved these changes
Aug 25, 2024
gayanSandamal
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When reconciling the
rowHeightinto the CSS vars, made an error on Fixed layouts which meant that the48pxwas then included ins a JS calculation for the width, failing (because of the inclusion ofpx) and then not setting the width properly.This PR ensures that
rowHeightis a number, before injecting it into the width calculations.Related Issue(s)
Fixes #1215