[fix]: Font-size supporting issue in ui-text node #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gayanSandamal
changed the title
gayanSandamal
changed the title
gayanSandamal
commented
Aug 12, 2024
| @@ -295,7 +295,7 @@ | |||
| "t": "set", | |||
| "p": "ui_update.fontSize", | |||
| "pt": "msg", | |||
| "to": "28px", | |||
| "to": "28", | |||
There was a problem hiding this comment.
Change this from 28px to 28 as we don't define the unit when setting the font size via the node-red widget editor under "Text Size"
|
I can confirm this fixes the issue for me. |
joepavitt
approved these changes
Aug 13, 2024
joepavitt
deleted the
1193-regression-styling-no-longer-working-in-ui-text-node
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the per the reported issue says "styling no longer applying" 1193.
I noticed that the only issue was with the
font sizeas it was just passed as a string without setting the unit as suffix.At moment the Dashboard 2.0 uses only pixel unit for font sizes I concatenated
pxunit in this fixRelated Issue(s)
#1193
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel