Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved add-on images to public directory #1189

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Conversation

gayanSandamal
Copy link
Contributor

Description

As the markdown files are static we cannot set asset paths as follows because the props passes as strings and it doesn't get the base url even if it's a dynamic Vue component.

Screenshot 2024-08-09 at 16 14 51

Therefore moved images of add-on to the public directory and referred from there.

Screenshot 2024-08-09 at 16 20 43

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@gayanSandamal gayanSandamal self-assigned this Aug 9, 2024
@gayanSandamal gayanSandamal added the area:docs Improvements or additions to documentation label Aug 9, 2024
@ZJvandeWeg ZJvandeWeg merged commit 66505b4 into main Aug 9, 2024
1 of 2 checks passed
@ZJvandeWeg ZJvandeWeg deleted the docs-broken-images branch August 9, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants