Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT - Table send clicked column #1170

Closed

Conversation

bartbutenaers
Copy link
Contributor

Description

Hi guys,
When you select a row in a ui-table widget, the clicked column will be send by this PR in the msg.column property:

table_column

I have this PR marked as draft because I wasn't sure whether the msg.column property is ok? Therefore I also haven't yet adapted any documentation...

Related Issue(s)

None

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@joepavitt
Copy link
Collaborator

I assume there is little value in this case now, but the linked PR re: button click would add further value?

@bartbutenaers
Copy link
Contributor Author

Yes true. I created this PR because I wanted this morning to show a recycle-bin icon in the last column. When clicked I could remove the corresponding data. But after some testing it is hard to see where you click, because the table shows no vertical lines...
That is why I created the next PR with the buttons.
So if you don't see added value, you can close this one...

@joepavitt
Copy link
Collaborator

I think your buttons PR covers what we'd like to see for this behaviour

@joepavitt joepavitt closed this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants