Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout: Tabs #1138

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Layout: Tabs #1138

merged 3 commits into from
Jul 31, 2024

Conversation

joepavitt
Copy link
Collaborator

@joepavitt joepavitt commented Jul 28, 2024 •
edited
Loading

Description

  • Adds a new "Tabs" layout to core Dashboard
  • Each group, rendered to a page will instead render to it's own "Tab" on that page.
  • Still needs some manual testing

Related Issue(s)

Closes #1119

Demo

Screen.Recording.2024-07-28.at.17.34.17.mov

@joepavitt joepavitt marked this pull request as draft July 28, 2024 16:36
@joepavitt joepavitt marked this pull request as ready for review July 30, 2024 13:08
@joepavitt joepavitt requested a review from gayanSandamal July 30, 2024 13:09
gayanSandamal
gayanSandamal approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@gayanSandamal gayanSandamal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab view is really cool 👌 Just a comment

You can ignore if it's not necessary.

LGTM

ui/src/layouts/Tabs.vue Outdated Show resolved Hide resolved
@joepavitt joepavitt merged commit 1429fb5 into main Jul 31, 2024
1 of 2 checks passed
@joepavitt joepavitt deleted the 1119-layout-tabs branch July 31, 2024 12:52
@omrid01
Copy link

omrid01 commented Jul 31, 2024

👍👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gayanSandamal gayanSandamal gayanSandamal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Layout: Tabs
3 participants
@joepavitt @omrid01 @gayanSandamal