Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI-ButtonGroup: Add msg.enabled support, validate msg.payload before apply to selection #1089

Merged
merged 5 commits into from
Jul 23, 2024
Merged

UI-ButtonGroup: Add msg.enabled support, validate msg.payload before apply to selection #1089

merged 5 commits into from
Jul 23, 2024

Conversation

arturv2000
Copy link
Contributor

Description

  • Add support for the msg.enabled property to allow enable/disable widget
  • Validate that msg.payload exists and it is valid to apply to selection
  • Add option to clear selection by sending an empty array

Related Issue(s)

Fixes #721

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

Artur Vieira added 3 commits July 13, 2024 12:19
Add enabled support
b52ae4b 
- Prevent assign new value to button if `msg-payload` does not exist
Validate msg.payload to update selected button
595ce21
Validate msg.payload content to update button selection
d458804 
Remove extra console.log
@joepavitt joepavitt self-requested a review July 18, 2024 07:58
@joepavitt
Copy link
Collaborator

joepavitt commented Jul 19, 2024 •
edited
Loading

The standard disabled styling of the button groups looked a little dated, so I've made an improvement as follows:

Before

Screenshot 2024-07-19 at 16 22 07 Screenshot 2024-07-19 at 16 22 34

After:

Screenshot 2024-07-19 at 16 20 29 Screenshot 2024-07-19 at 16 20 09

@joepavitt joepavitt merged commit 57c9384 into FlowFuse:main Jul 23, 2024
1 of 2 checks passed
@joepavitt joepavitt mentioned this pull request Jul 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joepavitt joepavitt joepavitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Button-Group: can be clicked in disabled state
2 participants
@arturv2000 @joepavitt