Fix: better handling of id replacement #42
Conversation
There was a problem hiding this comment.
Approved, but a little nervous for reasons I cannot yet a valid argument against.
While 99.9% of the time this will work as expected, I cant help but think there may be situations where the id exists as some other value in a node or API key or something.
I was going to suggest the replacement only works when surrounded by double quotes (i.e. strJson.replaceAll('"' + key + '"', '"' + idMap[key] + '"') but something in the back of my mind thinks I am missing something else.
Will let you decided Joe (I may be being over cautious)
even if that's the case, we don't want this new flow pointing to old flow instances, they all need updating.
We proceed as is, if new users report problems, we handle them |
Description
Wasn't supporting subflows and groups. This adds a more universal solution to the ID mapping we do to prevent Node-RED clashes on unchanged nodes.