Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add possibility to deploy emqx-exporter with FlowFuse helm chart #500

Merged
merged 8 commits into from
Nov 14, 2024

Conversation

ppawlowski
Copy link
Contributor

Description

This pull request adds a possibility to deploy emqx-exporter with FlowFuse Helm chart.
Aditionally, it simplifies the logic behind checking the availability of APIs required by EMQX cluster.

Related Issue(s)

https://github.com/FlowFuse/CloudProject/issues/559

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@ppawlowski ppawlowski requested a review from hardillb November 13, 2024 12:01
Copy link
Contributor

@hardillb hardillb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, just some comments on the secret_key_name, but I think they are OK

helm/flowforge/templates/_helpers.tpl Outdated Show resolved Hide resolved
helm/flowforge/templates/_helpers.tpl Show resolved Hide resolved
helm/flowforge/templates/emqx.yaml Show resolved Hide resolved
@ppawlowski
Copy link
Contributor Author

ppawlowski commented Nov 13, 2024

CI failure is caused by the chart testing tool reusing values file from the older chart version instead of the new one (helm/chart-testing#525).

@ppawlowski ppawlowski merged commit d01ac22 into main Nov 14, 2024
5 of 6 checks passed
@ppawlowski ppawlowski deleted the feat-emqx-observability branch November 14, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants