-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow env var values to be hidden in UI #5043
Conversation
… to reserved names
… to reserved names
…fter-creation' into 4835_set-env-vars-to-be-hidden-after-creation
…y selector state after var creation
…hat start with a number
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5043 +/- ##
=======================================
Coverage 78.41% 78.41%
=======================================
Files 329 329
Lines 15480 15494 +14
Branches 3574 3579 +5
=======================================
+ Hits 12138 12150 +12
- Misses 3342 3344 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@cstns can you add a screenshot of this in action? Helpful to see as part of the initial review, but can also be reused in changelog. |
Doing some testing with a Device - any env var with a hidden value ends up blank on the device. I haven't dug through the whole PR yet, but this change may be to blame as its code that's reused when sending info on the env vars to the front end as well as down to the device. |
You are right, i'll move this to be filtered on the controller side. The same thing is happening to instance vars |
Verified its working properly now. I'm wondering if the eye icon is clear enough as to what it does. Could we add a tooltip explaining its purpose? |
can you take a quick look over 9d8b069? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Description
Allows setting of hidden env vars, once set they can only be updated or removed
Related Issue(s)
closes #4835
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
area:migration
label