Replace the application activity instance selector, and FormRow dropdown with the listbox component #4591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cstns
changed the title
…dropdowns' into 4561_replace-the-applicationActivity-formRow-and-teamSlection-dropdowns
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4591 +/- ##
=======================================
Coverage 78.40% 78.40%
=======================================
Files 329 329
Lines 15478 15478
Branches 3574 3574
=======================================
Hits 12136 12136
Misses 3342 3342
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cstns
changed the title
Base automatically changed from
4562_replace-assetCompare-visibility-selector-and-logs-dropdowns
to
main
October 1, 2024 09:38
…-and-teamSlection-dropdowns
…-and-teamSlection-dropdowns
…-and-teamSlection-dropdowns
|
@cstns Is this ready for review? |
|
Not yet. Haven't gotten to finishing it due to other priorities. I'd move it into another state until I get to it but not sure which one would be appropriate |
|
@cstns no problem, was just walking the open PR list |
…icationActivity-formRow-and-teamSlection-dropdowns # Conflicts: # frontend/src/pages/application/Activity.vue
…icationActivity-formRow-and-teamSlection-dropdowns
cstns
changed the title
…-and-teamSlection-dropdowns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
closes #4561
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel