Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix containers resource requests missing last s #135

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Fix containers resource requests missing last s #135

merged 1 commit into from
Jan 26, 2024

Conversation

hardillb
Copy link
Contributor

Description

Typo, missing an s from the end of requests

https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#example-1

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@hardillb
Fix containers resource requests
03e12e3 
Typo, missing an `s` from the end of `requests`
@hardillb hardillb added this to the 2.1 milestone Jan 26, 2024
@hardillb hardillb requested a review from Steve-Mcl January 26, 2024 15:03
@hardillb hardillb self-assigned this Jan 26, 2024
@Steve-Mcl Steve-Mcl merged commit 0cf4885 into main Jan 26, 2024
3 checks passed
@Steve-Mcl Steve-Mcl deleted the fix-resource-requests branch January 26, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steve-Mcl Steve-Mcl Steve-Mcl approved these changes

Assignees

@hardillb hardillb

Labels
None yet
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@hardillb @Steve-Mcl