Send nr version

[hardillb]

Description

Has the the device agent report the currently running Node-RED version as part of it's regular check-in

This for use with the Device Editor Proxy.

Related Issue(s)

FlowFuse/flowfuse#3414

Checklist

• I have read the contribution guidelines
• Suitable unit/system level tests have been added and they pass
• Documentation has been updated
  • Upgrade instructions
  • Configuration details
  • Concepts
• Changes flowforge.yml?
  • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
  • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

• Includes a DB migration? -> add the area:migration label

[Steve-Mcl]

Ben, I can see a few other places in the code base where getAgent is called but without the async. And where they are, they have sync function signatures meaning the proliferation of the async await stuff has tentacles that reach even further out & I am unsure of the sideeffects in production.

TBH, I would be tempted to undo all of this and simply modify launcher.readPackage() to use readFileSync from fs.

There are only around ~5 calls to readPackage that would simply need to lose the await - then there would be no need to make getState async and no need to follow its code branches and parent callers adding await to everything it touches.

[Steve-Mcl]

Yeah, much cleaner without all the proliferating async await.

However, there is an issue with module vs modules and a couple of suggestions.

Lastly, do we thing a unit test is possible?

there is already tests in test/unit/lib/agent_spec.js around line 493 for getState - even just the presence of the property being a valid semver

[hardillb]

Lastly, do we thing a unit test is possible?

there is already tests in test/unit/lib/agent_spec.js around line 493 for getState - even just the presence of the property being a valid semver

I don't see how without having the test actually install Node-RED.

I already had to patch the code because the tests are injecting a JSON object rather than a real launcher object

[Steve-Mcl]

I don't see how without having the test actually install Node-RED.

I already had to patch the code because the tests are injecting a JSON object rather than a real launcher object

Fair enough Ben - just thought to ask.

[Steve-Mcl]

can we look at using semver.valid since semver is already a dependency?

Without this, I can foresee a future ticket where the nodeRedVersion is * or dev :)