Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit log crashes #310

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Audit log crashes #310

merged 3 commits into from
Aug 29, 2024

Conversation

Steve-Mcl
Copy link
Contributor

@Steve-Mcl Steve-Mcl commented Aug 27, 2024 •
edited
Loading

closes #309

Description

  • adds support for sending audit events from launcher (as nr-launcher does)
  • utilises above to send "crashed" event

tests:

  Launcher
    ✔ calls logAuditEvent when it crashes (84ms)

Related Issue(s)

owner #309
parent FlowFuse/flowfuse#4295

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@Steve-Mcl Steve-Mcl requested a review from hardillb August 27, 2024 15:46
@Steve-Mcl
Copy link
Contributor Author

@hardillb @joepavitt

Can we get this reviewed and merged for release?

The parent parts are all merged, this is the last peice.

NOTE: It is not critical - without it, crashed devices simply wont generate a notification.

joepavitt
joepavitt approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@joepavitt joepavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although I'll await Ben's more experience eyes in this space.

@hardillb hardillb merged commit 9350330 into main Aug 29, 2024
4 checks passed
@hardillb hardillb deleted the 309-audit-log-crahses branch August 29, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joepavitt joepavitt joepavitt approved these changes

@hardillb hardillb hardillb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Audit logging posting from Device Agent when NR crashes
3 participants
@Steve-Mcl @hardillb @joepavitt