Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect shared-library and projectComms feature flags #244

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

Steve-Mcl
Copy link
Contributor

part two of three

Description

  • Project Nodes Feature
    • Adds boolean featureEnabled to projectLink object which is persisted in the settings file
    • sets projectLink.broker.url, projectLink.broker.username & projectLink.broker.password to '' if featureEnabled===false
  • Shared Library Feature
    • Prevents library being loaded if its feature flag is false

Additional to this (happy to remove)

Added ability to run project-link nodes from source in developer environment by checking process.env.NODE_ENV === "development" and the nr-project-nodes src is in the expected relative location. This was necessary for testing the changes required for FlowFuse/flowfuse#3560
Would like to keep it but can remove if requested.

Related Issue(s)

FlowFuse/flowfuse#3560

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@knolleary knolleary merged commit dd703b5 into main Mar 19, 2024
2 checks passed
@knolleary knolleary deleted the 3560-obey-feature-flags branch March 19, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application bound Devices in Starter team are getting Project Nodes installed
2 participants