Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update core js - keyCacheWipe, key_mismatch fix, plainAtt data #335

Merged
merged 3 commits into from
Jun 13, 2021

Conversation

tomholub
Copy link
Collaborator

@tomholub tomholub commented Jun 4, 2021

This PR updates core functionality by adding a keyCacheWipe endpoint (useful when wiping pass phrase which was kept in memory) and ensuring that a mismatched message keys properly reports key_mismatch error even when missing a pass phrase.

Also plainAtt blocks are no longer filtered out of the response, so that they can be rendered / their content is can be downloaded for #194

issue #197


Tests (delete all except exactly one):


To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@tomholub
Copy link
Collaborator Author

tomholub commented Jun 4, 2021

discussion at FlowCrypt/flowcrypt-android#1251 (comment)

@tomholub tomholub requested a review from ekievsky June 4, 2021 11:55
@tomholub tomholub enabled auto-merge (squash) June 4, 2021 11:55
@tomholub tomholub disabled auto-merge June 4, 2021 11:55
@tomholub tomholub enabled auto-merge (squash) June 4, 2021 11:56
@tomholub tomholub requested a review from Kharchevskyi June 4, 2021 11:56
@tomholub
Copy link
Collaborator Author

@ekievsky or @Kharchevskyi please have a look that the app still works as expected and if so, approve or add comments. Thanks!

@Kharchevskyi
Copy link
Contributor

Tested on update-core branch and also by pulling in feature/issue-197-pass-phrase-memory. Functionality works fine

@tomholub
Copy link
Collaborator Author

@Kharchevskyi then you can go to Files changed -> Review changes -> Approve and that will merge the PR. Thanks!

@tomholub tomholub changed the title updated core js - keyCacheWipe and key_mismatch fix updated core js - keyCacheWipe, key_mismatch fix, plainAtt data Jun 12, 2021
@tomholub tomholub changed the title updated core js - keyCacheWipe, key_mismatch fix, plainAtt data update core js - keyCacheWipe, key_mismatch fix, plainAtt data Jun 12, 2021
@tomholub tomholub merged commit a9908db into master Jun 13, 2021
@tomholub tomholub deleted the update-core branch June 13, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants