Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2580 Implement better detection of "multipart/encrypted" email with PGP encrypted message #2643

Merged
merged 3 commits into from
Nov 15, 2024
Merged

#2580 Implement better detection of "multipart/encrypted" email with PGP encrypted message #2643

merged 3 commits into from
Nov 15, 2024

Conversation

ioanmo226
Copy link
Collaborator

This PR implemented better detection of "multipart/encrypted" email with PGP encrypted message

close #2580 // if this PR closes an issue

Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@ioanmo226 ioanmo226 marked this pull request as ready for review November 15, 2024 01:37
@ioanmo226 ioanmo226 requested a review from sosnovsky as a code owner November 15, 2024 01:37
sosnovsky
sosnovsky reviewed Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well 👍

FlowCrypt/Functionality/Mail Provider/Message Provider/Gmail+MessageExtension.swift Outdated Show resolved Hide resolved
appium/tests/specs/mock/inbox/CheckCanaryMail.spec.ts Outdated Show resolved Hide resolved
@ioanmo226 ioanmo226 requested a review from sosnovsky November 15, 2024 10:47
sosnovsky
sosnovsky approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sosnovsky sosnovsky merged commit 52edb18 into master Nov 15, 2024
10 checks passed
@sosnovsky sosnovsky deleted the 2580-implement-better-detection-of-multipartencrypted-email-with-pgp-encrypted-message branch November 15, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosnovsky sosnovsky sosnovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement better detection of "multipart/encrypted" email with PGP encrypted message
2 participants
@ioanmo226 @sosnovsky