Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2614 fix: decryption error for message sent via encrypted contact page #2640

Conversation

ioanmo226
Copy link
Collaborator

@ioanmo226 ioanmo226 commented Oct 25, 2024

This PR fixed decryption error for message sent via encrypted contact page

close #2614 // if this PR closes an issue


Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@ioanmo226
Copy link
Collaborator Author

@martgil I'm attempting to send an encrypted message via the encrypted contact page to [email protected] for a UI test, but it's throwing the following error.

Could you check the error log and let me know what's causing this? This issue is currently blocking me from implementing the UI test for this fix.

image

@martgil
Copy link
Collaborator

martgil commented Oct 28, 2024

Hi @ioanmo226 could be because of expired key most probably.

To verify this claim of mine, please kindly run this public key to the flowcrypt browser extension's compatibility checker: https://flowcrypt.com/pub/[email protected]?show=pubkey

The openpgp compatibility checker is in the advanced settings of FlowCrypt settings > experimental.

Observe if the keys are expired (most probably).

Once confirmed, please extend the keys expiration and submit the updated keys to https://flowcrypt.com/attester/update-public-keys

I have the PR on flowcrypt-web for fixing the missing error message details for expired keys and is already under review by Roma.

Hope this helps.

@ioanmo226
Copy link
Collaborator Author

Hmmmm... Just checked but I think it's not expired yet?
image

@martgil
Copy link
Collaborator

martgil commented Oct 28, 2024

The issue looks like something else. The key doesnt look expired either. Unfortunately, I dont have access to my computer right now to check the issue but can check it tomorrow if its okay?

@ioanmo226
Copy link
Collaborator Author

No problem at all. I can work on other issue.

@martgil
Copy link
Collaborator

martgil commented Oct 28, 2024

Got it - thanks!

@sosnovsky
Copy link
Collaborator

Hi @ioanmo226, mentioned error happens because our config doesn't allow senders from flowcrypt.com domain:

Screenshot 2024-10-28 at 23 13 44

To send encrypted message you should just change email address to non-flowcrypt domain.

@ioanmo226
Copy link
Collaborator Author

Aha, I see. Thank for checking it.

@ioanmo226
Copy link
Collaborator Author

However I think we should display actual error message response.error.message (Senders on flowcrypt.com domain not allowed) instead of "Server says this was a bad request" generic error message

@martgil
Copy link
Collaborator

martgil commented Oct 29, 2024

Hi @ioanmo226 - yes, I will include this case to my PR right now: https://github.com/FlowCrypt/flowcrypt-web/pull/1856

@martgil
Copy link
Collaborator

martgil commented Oct 29, 2024

I'm done at adding some error handling for the reported issue; Already included in https://github.com/FlowCrypt/flowcrypt-web/pull/1856.

@ioanmo226 ioanmo226 marked this pull request as ready for review October 30, 2024 05:51
@ioanmo226 ioanmo226 requested a review from sosnovsky as a code owner October 30, 2024 05:51
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well 👍

@sosnovsky sosnovsky merged commit a67406d into master Oct 30, 2024
11 checks passed
@sosnovsky sosnovsky deleted the 2614-decryption-error-for-message-sent-via-encrypted-contact-page branch October 30, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decryption error for message sent via Encrypted Contact Page
3 participants