-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2614 fix: decryption error for message sent via encrypted contact page #2640
#2614 fix: decryption error for message sent via encrypted contact page #2640
Conversation
@martgil I'm attempting to send an encrypted message via the encrypted contact page to Could you check the error log and let me know what's causing this? This issue is currently blocking me from implementing the UI test for this fix. |
Hi @ioanmo226 could be because of expired key most probably. To verify this claim of mine, please kindly run this public key to the flowcrypt browser extension's compatibility checker: https://flowcrypt.com/pub/[email protected]?show=pubkey The openpgp compatibility checker is in the advanced settings of FlowCrypt settings > experimental. Observe if the keys are expired (most probably). Once confirmed, please extend the keys expiration and submit the updated keys to https://flowcrypt.com/attester/update-public-keys I have the PR on flowcrypt-web for fixing the missing error message details for expired keys and is already under review by Roma. Hope this helps. |
The issue looks like something else. The key doesnt look expired either. Unfortunately, I dont have access to my computer right now to check the issue but can check it tomorrow if its okay? |
No problem at all. I can work on other issue. |
Got it - thanks! |
Hi @ioanmo226, mentioned error happens because our config doesn't allow senders from To send encrypted message you should just change email address to non-flowcrypt domain. |
Aha, I see. Thank for checking it. |
However I think we should display actual error message response.error.message (Senders on flowcrypt.com domain not allowed) instead of "Server says this was a bad request" generic error message |
Hi @ioanmo226 - yes, I will include this case to my PR right now: https://github.com/FlowCrypt/flowcrypt-web/pull/1856 |
I'm done at adding some error handling for the reported issue; Already included in https://github.com/FlowCrypt/flowcrypt-web/pull/1856. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well 👍
This PR fixed decryption error for message sent via encrypted contact page
close #2614 // if this PR closes an issue
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):