Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2366 Reload inbox view when index was not found #2379

Merged
merged 2 commits into from
Sep 28, 2023
Merged

#2366 Reload inbox view when index was not found #2379

merged 2 commits into from
Sep 28, 2023

Conversation

ioanmo226
Copy link
Collaborator

@ioanmo226 ioanmo226 commented Sep 28, 2023 •
edited by sosnovsky
Loading

This PR reloads inbox view when index was not found.

close #2366 // if this PR closes an issue

Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@ioanmo226 ioanmo226 marked this pull request as ready for review September 28, 2023 13:33
@ioanmo226 ioanmo226 requested a review from sosnovsky September 28, 2023 15:35
sosnovsky
sosnovsky approved these changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sosnovsky sosnovsky merged commit d00c252 into master Sep 28, 2023
5 checks passed
@sosnovsky sosnovsky deleted the 2366-archive-doesnt-remove-item-from-inbox-until-refreshed-sometimes branch September 28, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosnovsky sosnovsky sosnovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

archive doesn't remove item from inbox until refreshed - sometimes
2 participants
@ioanmo226 @sosnovsky