Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2350 Added icons to Inbox items #2359

Merged

Conversation

ioanmo226
Copy link
Collaborator

@ioanmo226 ioanmo226 commented Sep 15, 2023

This PR added encrypted, public key, attachment icons to Inbox items

close #2350 // if this PR closes an issue

image


Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@ioanmo226 ioanmo226 marked this pull request as ready for review September 15, 2023 14:20
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition to UI 👍

@ioanmo226 ioanmo226 requested a review from sosnovsky September 19, 2023 13:17
…on-ios' of github.com:FlowCrypt/flowcrypt-ios into 2350-add-encrypted-attachment-icon-to-thread-list-view-on-ios
@ioanmo226 ioanmo226 requested a review from sosnovsky September 20, 2023 12:47
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great now 👍

@sosnovsky sosnovsky merged commit 26c05b1 into master Sep 20, 2023
@sosnovsky sosnovsky deleted the 2350-add-encrypted-attachment-icon-to-thread-list-view-on-ios branch September 20, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Encrypted & Attachment Icon to Thread List View on iOS
3 participants