Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SwiftyRSA and IDZSwiftCommonCrypto libs #2346

Merged
merged 3 commits into from
Sep 5, 2023
Merged

Remove SwiftyRSA and IDZSwiftCommonCrypto libs #2346

merged 3 commits into from
Sep 5, 2023

Conversation

sosnovsky
Copy link
Collaborator

@sosnovsky sosnovsky commented Sep 5, 2023 •
edited by ioanmo226
Loading

This PR removes SwiftyRSA lib (as it's not used) and replaces IDZSwiftCommonCrypto with built-in iOS CryptoKit framework

Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@sosnovsky sosnovsky requested a review from ioanmo226 September 5, 2023 07:46
ioanmo226
ioanmo226 approved these changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@ioanmo226 ioanmo226 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ioanmo226 ioanmo226 merged commit 1b48130 into master Sep 5, 2023
@ioanmo226 ioanmo226 deleted the 000-remove-swifty-rsa branch September 5, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ioanmo226 ioanmo226 ioanmo226 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sosnovsky @ioanmo226