-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1233 Decrypt attachments on tap #1323
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. That made me think: there are three types of attachments:
- plain / not encrypted
- encrypted as a separate file
- encrypted with pgp/mime (a mime message with attachments, encrypted whole)
Could you double check that the third case works after this change? Please try email with subject [enigmail] encrypted+signed+file PGP/MIME
on flowcrypt.compatibiltiy
account.
I supose the TS core will auto-decrypt it and return back as decrypted (plain), which should work. Worth checking though.
Here is how it works in this branch Simulator.Screen.Recording.-.iPhone.13.-.2022-01-20.at.22.28.17.mp4Signature can't be verified, but I get the same error on |
The same signature error is in browser extension, so should be good |
Looks perfect 👍 |
Just the tests to fix else looks great to me. |
This PR implements attachments decrypt on tap, so they're not decrypted on message open.
close #1233
Tests (delete all except exactly one):
user is able to view message processing errors
anduser is able to view encrypted email with attachment
testsTo be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):