Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only encrypt for valid keys when sending message #744

Closed
tomholub opened this issue Oct 22, 2021 · 1 comment · Fixed by #821
Closed

only encrypt for valid keys when sending message #744

tomholub opened this issue Oct 22, 2021 · 1 comment · Fixed by #821
Assignees
@sosnovsky
Labels
actionable PR Submitted PR is submitted for this issue
Milestone
0.3.2: Recipient ...

Comments

@tomholub
Copy link
Collaborator

test recipients @flowcrypt.com:

  • valid.expired
  • valid.revoked
  • valid.expired.revoked

As long as at least one of the returned public keys is valid, it should use that key and ignore the bad keys.
@tomholub tomholub added this to the 0.3.1 milestone Oct 22, 2021
@tomholub tomholub self-assigned this Oct 22, 2021
@tomholub tomholub changed the title test behavior with mixed keys only encrypt for valid keys when sending message Oct 23, 2021
@tomholub tomholub assigned sosnovsky and unassigned tomholub Oct 23, 2021
@tomholub
Copy link
Collaborator Author

You may test with the above three email addresses. Current behavior is:

  • show recipient status based on first of the keys for each recipient
  • encrypt for all received public keys of each recipient, regardless of key status

Desired behavior is:

  • show recipient status based on first of the keys for each recipient (same)
  • check status of all recipients and show modal (and cancel action) if not all recipients are green more fitting modals when recipient key is revoked or expired #732
  • if you passed the above check, filter keys for each recipient to only include valid keys. Do one more sanity check to make sure each recipient contains at least one valid key.
  • encrypt message with the filtered (valid only) keys

sosnovsky added a commit that referenced this issue Oct 27, 2021
@sosnovsky
issue #744 encrypt only for valid keys
9bdb1b2
sosnovsky added a commit that referenced this issue Oct 28, 2021
@sosnovsky
issue #744 add test for key validation
dd707f4
@sosnovsky sosnovsky mentioned this issue Oct 28, 2021
Merged
5 tasks
@sosnovsky sosnovsky added the PR Submitted PR is submitted for this issue label Oct 28, 2021
tomholub pushed a commit that referenced this issue Oct 28, 2021
@sosnovsky @flowcrypt-machine-user
Feature/issue 732 compose pub key validation + filtering (#821)
838917c 
* issue #732 add expired and revoked recipient modals

* issue #732 add invalid email error

* issue #744 encrypt only for valid keys

* issue #732 ComposeMessageServiceTests updates

* issue #732 fix tests

* issue #732 add tests for message validation

* issue #744 add test for key validation

Co-authored-by: Tom <[email protected]>
@tomholub tomholub mentioned this issue Nov 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sosnovsky sosnovsky

Labels
actionable PR Submitted PR is submitted for this issue
Projects
None yet
Milestone
0.3.2: Recipient public keys
Development

Successfully merging a pull request may close this issue.

Feature/issue 732 compose pub key validation FlowCrypt/flowcrypt-ios
2 participants
@sosnovsky @tomholub