Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show links to remote images #2414

Closed
sosnovsky opened this issue Oct 26, 2023 · 4 comments · Fixed by #2422
Closed

Show links to remote images #2414

sosnovsky opened this issue Oct 26, 2023 · 4 comments · Fixed by #2422
Assignees
@ioanmo226
Milestone
1.3.0: Maintenance

Comments

@sosnovsky
Copy link
Collaborator 

          Was not sure where to post this - but on IOS Mobile Flowcrypt App there is no button for "Show Remote Images" - it just says in text "Remote content blocked for your privacy" and I cant find any settings to allow loading of remote images (which in case of some email I am getting is essential to approve security requests (they come as image with link and flowcrypt mobile does not load neither the image nor the link - while in gmail on desktop it loads images and links fine)

Originally posted by @kubadoki in FlowCrypt/flowcrypt-browser#4759 (comment)
@sosnovsky sosnovsky added this to the 1.3.0: Maintenance milestone Oct 26, 2023
@sosnovsky
Copy link
Collaborator Author

let's handle it the same way as on Android:

  • add remote content blocked for your privacy label
  • show link to remote image

@sosnovsky sosnovsky mentioned this issue Oct 26, 2023
Closed
@ioanmo226
Copy link
Collaborator

@sosnovsky Could you tell me reproduce steps?
Currently iOS app shows links to image whether message is encrypted or not.

image

@sosnovsky
Copy link
Collaborator Author

@ioanmo226 I sent you email message with such image.
To reproduce you should add image to non-encrypted message using Gmail's Insert photo -> Web Address (URL)

@ioanmo226
Copy link
Collaborator

Got it. Thank you

@ioanmo226 ioanmo226 mentioned this issue Nov 1, 2023
Merged
5 tasks
sosnovsky pushed a commit that referenced this issue Nov 24, 2023
@ioanmo226
#2414 Show links to remote images (#2422)
086d22c 
* show remote image link

* fix: added and fixed ui test

* fix: pr reviews

* temp: added web node

* Revert "temp: added web node"

This reverts commit bfd9a69.

* fix: clean up

* fix: web node

* fix: remove time delay when calculating web view height

* fix: keep style attributes

* ui test

* fix: unit test

* feat: added ability to inspect web view

* fix: pr reviews

* fix: pr reviews

* fix: pr reviews
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ioanmo226 ioanmo226

Labels
None yet
Projects
None yet
Milestone
1.3.0: Maintenance
Development

Successfully merging a pull request may close this issue.

#2414 Show links to remote images FlowCrypt/flowcrypt-ios
2 participants
@sosnovsky @ioanmo226