Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanups after Realm init AppContext PR #1135

Closed
tomholub opened this issue Dec 1, 2021 · 0 comments · Fixed by #1190
Closed

cleanups after Realm init AppContext PR #1135

tomholub opened this issue Dec 1, 2021 · 0 comments · Fixed by #1190
Assignees
@ivan-ushakov
Labels
actionable PR Submitted PR is submitted for this issue
Milestone
0.6.0: Maintenanc...

Comments

@tomholub
Copy link
Collaborator

tomholub commented Dec 1, 2021

Below are smaller cleanup/refactors that I wanted to do in this PR

Originally posted by @tomholub in #1117 (review)
@tomholub tomholub added this to the 0.6.0: Maintenance milestone Dec 1, 2021
@ivan-ushakov ivan-ushakov mentioned this issue Dec 7, 2021
Merged
5 tasks
@ivan-ushakov ivan-ushakov added in progress Work on the issue is in progress PR Submitted PR is submitted for this issue labels Dec 7, 2021
tomholub pushed a commit that referenced this issue Dec 8, 2021
@ivan-ushakov
issue #1135 Cleanups after Realm init AppContext PR (#1190)
d09e501 
* Cleanups after Realm init AppContext PR

* Code review fixes
@tomholub tomholub removed the in progress Work on the issue is in progress label Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivan-ushakov ivan-ushakov

Labels
actionable PR Submitted PR is submitted for this issue
Projects
None yet
Milestone
0.6.0: Maintenance, preview, forward
Development

Successfully merging a pull request may close this issue.

Cleanups after Realm init AppContext PR FlowCrypt/flowcrypt-ios
2 participants
@ivan-ushakov @tomholub