Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#5886 Fix: failed to execute json on response error in console on message send #5892

Merged
merged 1 commit into from
Jan 1, 2025
Merged

#5886 Fix: failed to execute json on response error in console on message send #5892

merged 1 commit into from
Jan 1, 2025

Conversation

ioanmo226
Copy link
Collaborator

@ioanmo226 ioanmo226 commented Dec 30, 2024 •
edited by sosnovsky
Loading

This PR fixed failed to execute json on response error in console on message send

close #5886 // if this PR closes an issue

Tests (delete all except exactly one):

  • Difficult to test (Can't simulate this in CI environment)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@ioanmo226 ioanmo226 marked this pull request as ready for review December 31, 2024 00:10
@ioanmo226 ioanmo226 requested a review from sosnovsky as a code owner December 31, 2024 00:10
sosnovsky
sosnovsky approved these changes Jan 1, 2025
View reviewed changes
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well now, thanks!

@sosnovsky sosnovsky merged commit 2381926 into master Jan 1, 2025
13 checks passed
@sosnovsky sosnovsky deleted the 5886-failed-to-execute-json-on-response-error-in-console-on-message-send branch January 1, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosnovsky sosnovsky sosnovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Failed to execute 'json' on 'Response'" error in console on message send
2 participants
@ioanmo226 @sosnovsky