Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5888 Update border for Secure Compose button #5891

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

martgil
Copy link
Collaborator

@martgil martgil commented Dec 30, 2024

This PR only updates the CSS for FlowCrypt's secure compose to have identical UI with Gmail's compose button.

The UI does not affect any other existing CSS plus 3 secure compose UI locations we're perfectly aligned. Even the 3rd case where it still matches for slightly rounded Gmail buttons.

Screenshots:

image image image

close #5888


Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@martgil martgil requested a review from sosnovsky as a code owner December 30, 2024 12:39
@martgil
Copy link
Collaborator Author

martgil commented Dec 30, 2024

@sosnovsky - This one is ready for a review. Thank you!

Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@sosnovsky sosnovsky enabled auto-merge (squash) December 30, 2024 20:00
@sosnovsky sosnovsky merged commit 5c2684e into master Dec 30, 2024
12 of 13 checks passed
@sosnovsky sosnovsky deleted the issue-5888-secure-compose-button-revamp branch December 30, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggested UI improvement for Secure Compose
2 participants