Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5133 Fix broken email threading for draft messages #5874

Merged
merged 9 commits into from
Dec 4, 2024

Conversation

martgil
Copy link
Collaborator

@martgil martgil commented Nov 27, 2024

This PR fixes the broken email threading for FlowCrypt's secure draft messages.

close #5133


Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@martgil martgil requested a review from sosnovsky as a code owner November 27, 2024 10:15
@martgil martgil marked this pull request as draft November 27, 2024 10:15
@martgil martgil marked this pull request as ready for review November 28, 2024 08:28
@martgil
Copy link
Collaborator Author

martgil commented Nov 28, 2024

Hi @sosnovsky - this one is ready for review. Thank you!

Please follow the manual test below:

  1. User 1 send to user 2,3 using FlowCrypt (via to, cc would work too).
  2. As user 2, compose a secure reply -> go back to make a draft.
  3. Access the draft from Gmail's draft folder.
  4. Send the secure email reply.
  5. See the sent reply as User 1, and notice you'll not be receiving replies in new thread and subject line will not prepended with term "Re:"

Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works correct now, great job on finding bug origin 👏

@martgil martgil requested a review from sosnovsky November 29, 2024 05:43
@martgil

This comment was marked as off-topic.

@martgil martgil marked this pull request as draft November 29, 2024 06:31
@martgil

This comment was marked as off-topic.

@martgil martgil marked this pull request as ready for review November 29, 2024 09:31
@martgil

This comment was marked as outdated.

@martgil martgil requested a review from sosnovsky November 29, 2024 11:45
@martgil

This comment was marked as outdated.

@martgil martgil requested a review from sosnovsky November 30, 2024 11:02
@martgil

This comment was marked as off-topic.

1 similar comment
@martgil
Copy link
Collaborator Author

martgil commented Dec 2, 2024

Hello @sosnovsky, I've added a few improvements, including the fix for the requested change. Thanks!

Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now, thanks!

@sosnovsky sosnovsky enabled auto-merge (squash) December 4, 2024 07:31
@martgil
Copy link
Collaborator Author

martgil commented Dec 4, 2024

Thanks Roma for reviewing this.

@sosnovsky sosnovsky merged commit 9a50933 into master Dec 4, 2024
12 of 13 checks passed
@sosnovsky sosnovsky deleted the issue-5133-fix-broken-threading branch December 4, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken threading after replying from Firefox
2 participants