-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#5133 Fix broken email threading for draft messages #5874
Conversation
Hi @sosnovsky - this one is ready for review. Thank you! Please follow the manual test below:
|
extension/js/content_scripts/webmail/gmail/gmail-element-replacer.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works correct now, great job on finding bug origin 👏
extension/js/content_scripts/webmail/gmail/gmail-element-replacer.ts
Outdated
Show resolved
Hide resolved
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
extension/chrome/elements/compose-modules/compose-render-module.ts
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
extension/chrome/elements/compose-modules/compose-render-module.ts
Outdated
Show resolved
Hide resolved
This comment was marked as off-topic.
This comment was marked as off-topic.
1 similar comment
Hello @sosnovsky, I've added a few improvements, including the fix for the requested change. Thanks! |
extension/chrome/elements/compose-modules/compose-render-module.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good now, thanks!
Thanks Roma for reviewing this. |
This PR fixes the broken email threading for FlowCrypt's secure draft messages.
close #5133
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):