-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#5839 Fix parsing noname attachment with "message/global" content type #5844
Conversation
Hi @martgil, this PR is ready for review, thanks! |
Looks good to me – I just noticed one minor thing that could be improved, but it’s definitely not an issue. |
Hi @martgil, didn't find this minor thing, can you please describe what can be improved, thanks! |
# Conflicts: # package-lock.json
Hi @martgil, can you please describe mentioned improvement, thanks! |
Thanks @sosnovsky, I'm referring to this one: https://github.com/FlowCrypt/flowcrypt-browser/pull/5844/files#diff-fb2223e49c2a9c6a1085bdbe7eb8e17e3ee803132833d5e90d49faf5a3e8d2faR232-R237 I feel like this function should be renamed to if (renderStatus === 'hidden' || a.isHidden()) {
nRenderedAttachments--;
} since there's an action that depends on it that requires reduction for attachment that is supposed to be hidden. The function |
Agree on this, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good now, thank you!
This PR fixes incorrect parsing of
noname
attachments withmessage/global
content type in plain messages.close #5839
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):