Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5822 Fix: deprecated errors #5842

Merged
merged 5 commits into from
Sep 25, 2024

Conversation

ioanmo226
Copy link
Collaborator

@ioanmo226 ioanmo226 commented Sep 24, 2024

This PR fixed deprecated errors

close #5822 // if this PR closes an issue


Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@ioanmo226 ioanmo226 marked this pull request as ready for review September 24, 2024 12:57
extension/js/common/inject.ts Outdated Show resolved Hide resolved
extension/js/common/browser/browser.ts Outdated Show resolved Hide resolved
@ioanmo226 ioanmo226 requested a review from sosnovsky September 25, 2024 14:00
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 👍

@sosnovsky sosnovsky merged commit 3d5821d into master Sep 25, 2024
13 checks passed
@sosnovsky sosnovsky deleted the 5822-fix-typescript-eslintno-deprecated-errors branch September 25, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix 'typescript-eslint/no-deprecated' errors
2 participants