-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#5801 Differentiate GoogleAuthErr And EnterpriseServerAuthErr #5814
#5801 Differentiate GoogleAuthErr And EnterpriseServerAuthErr #5814
Conversation
…serverautherr-when-custom-idp-is-used
…serverautherr-when-custom-idp-is-used
Hi @ioanmo226, I haven't fully tested implementation yet, but can you please also add ui test for checking if correct auth modal is shown when custom IdP is configured and Enterprise Server error is received. It's quite important functionality, so better have it tested to be sure that it works well after future code changes. |
Ohh. Yep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done, works great 👍
This PR implemented function to refresh custom idp id token if expires and show custom idp auth popup when auth error occurs
close #5801 // if this PR closes an issue
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):