Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5801 Differentiate GoogleAuthErr And EnterpriseServerAuthErr #5814

Conversation

ioanmo226
Copy link
Collaborator

@ioanmo226 ioanmo226 commented Aug 14, 2024

This PR implemented function to refresh custom idp id token if expires and show custom idp auth popup when auth error occurs

close #5801 // if this PR closes an issue


Tests (delete all except exactly one):

  • Test added

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@ioanmo226 ioanmo226 marked this pull request as ready for review August 15, 2024 08:07
@ioanmo226 ioanmo226 requested a review from sosnovsky as a code owner August 15, 2024 08:07
@sosnovsky
Copy link
Collaborator

Hi @ioanmo226, I haven't fully tested implementation yet, but can you please also add ui test for checking if correct auth modal is shown when custom IdP is configured and Enterprise Server error is received. It's quite important functionality, so better have it tested to be sure that it works well after future code changes.

@ioanmo226
Copy link
Collaborator Author

Ohh. Yep
It's necessary to add UI test.
Let me add that.

Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, works great 👍

@sosnovsky sosnovsky merged commit 9ba4d97 into master Aug 16, 2024
13 checks passed
@sosnovsky sosnovsky deleted the differentiate-googleautherr-and-enterpriseserverautherr-when-custom-idp-is-used-live-test branch August 16, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants