Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ESLint config #5813

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Update ESLint config #5813

merged 1 commit into from
Aug 13, 2024

Conversation

sosnovsky
Copy link
Collaborator

@sosnovsky sosnovsky commented Aug 13, 2024

This PR updates ESLint config, as previously full set of rules was not applied to some files.
It caused npm run test_eslint to pass without errors, while vs code and lint-staged displayed ESLint errors.

no issue


Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@sosnovsky sosnovsky requested a review from ioanmo226 August 13, 2024 10:36
Copy link
Collaborator

@ioanmo226 ioanmo226 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ioanmo226 ioanmo226 merged commit 748b960 into master Aug 13, 2024
13 checks passed
@ioanmo226 ioanmo226 deleted the eslint-config-update branch August 13, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants