Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5736 Group similar error reports #5750

Merged
merged 4 commits into from
May 31, 2024
Merged

#5736 Group similar error reports #5750

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0394679
feat: group similar error reports
ioanmo226 May 31, 2024
975f2e6
fix: remove unnecessary line
ioanmo226 May 31, 2024
b2a318f
fix: simplify code
ioanmo226 May 31, 2024
740464b
fix: pr reviews
ioanmo226 May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions extension/js/common/platform/catch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,14 @@ export class Catch {
}
}

private static groupSimilarReports(value: string): string {
return value
.replace(/chrome-extension:\/\/[^\/]+\//, 'chrome-extension://EXTENSION_ID/')
.replace(/https:\/\/www\.googleapis\.com\/gmail\/v1\/users\/me\/threads\/[^\/]+/, 'https://www.googleapis.com/gmail/v1/users/me/threads/THREAD_ID')
.replace(/https:\/\/www\.googleapis\.com\/gmail\/v1\/users\/me\/messages\/[^\/]+/, 'https://www.googleapis.com/gmail/v1/users/me/messages/MESSAGE_ID')
.replace(/https:\/\/www\.googleapis\.com\/gmail\/v1\/users\/me\/drafts\/[^\/]+/, 'https://www.googleapis.com/gmail/v1/users/me/drafts/DRAFT_ID');
}

private static formatExceptionForReport(thrown: unknown, line?: number, col?: number): ErrorReport {
if (!line || !col) {
const { line: parsedLine, col: parsedCol } = Catch.getErrorLineAndCol(thrown);
Expand All @@ -298,11 +306,11 @@ export class Catch {
const exception = Catch.formExceptionFromThrown(thrown);
return {
name: exception.name.substring(0, 50),
message: exception.message.substring(0, 200),
url: location.href.split('?')[0],
message: Catch.groupSimilarReports(exception.message.substring(0, 200)),
url: Catch.groupSimilarReports(location.href.split('?')[0]),
line: line || 1,
col: col || 1,
trace: exception.stack || '',
trace: Catch.groupSimilarReports(exception.stack || ''),
version: VERSION,
environment: Catch.RUNTIME_ENVIRONMENT,
product: 'web-ext',
Expand Down
Loading