Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlowCrypt's secure forward icon button become less obvious in UI #5858

Closed
martgil opened this issue Nov 8, 2024 · 5 comments · Fixed by #5870
Closed

FlowCrypt's secure forward icon button become less obvious in UI #5858

martgil opened this issue Nov 8, 2024 · 5 comments · Fixed by #5870
Assignees

Comments

@martgil
Copy link
Collaborator

martgil commented Nov 8, 2024

Description: The FlowCrypt's "secure forward" button is present for a single thread email that is new and doesnt have any reply.

However, the "secure forward" feature is missing in case there already an exchange of message and the "secure forward" feature is missing in UI unless it is accessed by clicking "secure compose" icon on the right-side of the secure email -> default behavior is "secure reply" upon clicking it which then be switchable to "secure forward" by clicking the option to change it on the upper-left corner of the secure compose.

Steps to reproduce:

  1. In Gmail with FlowCrypt extension is installed, access a PGP email thread.
  2. Find a secure reply icon button in any of the FlowCrypt recognizable email and click it.
  3. Once the secure compose box is opened, notice that its it FlowCrypt reply behavior which is correct.
  4. Notice that at this point, its not so obvious that "secure forward" and needs to switch from secure reply to secure forward.

Expected Behaviour:

The "secure forward" Icon button is present on older version of FlowCrypt, similar to "secure reply" icon button present in right-hand side of every secure emails.

Screenshot:

image

@martgil martgil changed the title FlowCrypt's secure forward become less obvious in UI FlowCrypt's secure forward icon button become less obvious in UI Nov 8, 2024
@martgil martgil added this to the 8.5.9 milestone Nov 8, 2024
@sosnovsky
Copy link
Collaborator

Hmm, I don't remember secure forward button on the email message toolbar. Checked screenshots at Chrome web store and they show only secure reply button there too.
I think it's fine to have only a secure reply button, as secure forward is used much less often.

@sosnovsky
Copy link
Collaborator

there is also secure forward button on this bottom toolbar:

Screenshot 2024-11-08 at 15 25 58

@martgil
Copy link
Collaborator Author

martgil commented Nov 16, 2024

Yes, we have that working but only when:

(1) a secure email is detected

But not when:

(1) the last email of an email thread is a non-encrypted email - will show gmail's regular reply and forwards.

there is also secure forward button on this bottom toolbar

I can agree on this. But for some email that are in the middle of the email conversation that needs to be securely fowarded with FlowCrypt extension, having to click on secure reply and going to secure foward option maybe too much of an interaction in a users perspective over having them the ability to secure forward right away in a single click. What do you think?

I think it's fine to have only a secure reply button, as secure forward is used much less often.

@sosnovsky
Copy link
Collaborator

Having another button in message toolbar probably will be too much, but it would be great if we were able to add secure forward and secure reply actions to the message actions menu which opens after clicking 3-dot button:

Screenshot 2024-11-19 at 15 03 42

@martgil
Copy link
Collaborator Author

martgil commented Nov 20, 2024

I like this idea, its clean and a good placement for "secure forward" and "secure reply". I think its already possible as I checked the DOM structure of the menu and its accessible and seemed to be inject-able too. The box's accessible id is .b7.J-M - just noting it here so I won't miss it.

sosnovsky pushed a commit that referenced this issue Nov 29, 2024
…5870)

* add "secure reply" option in Gmail actions menu

* add base ui for secure forward

* fix forward icon

* add secure forward functionality

* add test

* revert unneeded changes

* update test

* update test

* remove unneeded attributes

* pr reviews: make code concise
@sosnovsky sosnovsky modified the milestones: 8.5.9, 8.5.8 Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment