Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error reports send unauthorized requests from content script #5715

Closed
sosnovsky opened this issue May 14, 2024 · 0 comments · Fixed by #5717
Closed

Error reports send unauthorized requests from content script #5715

sosnovsky opened this issue May 14, 2024 · 0 comments · Fixed by #5717
Assignees
@sosnovsky
Labels
actionable
Milestone
8.5.5: Manifest V3

Comments

@sosnovsky
Copy link
Collaborator

When sending error report from content script, idToken is undefined which causes 401 Unauthorized error on FES.

It happens because in doSendErrorToSharedTenantFes we try to parse acctEmail from current url, but there is no such url parameter in content script, need to fetch current acctEmail from storage.
@sosnovsky sosnovsky added this to the 8.5.5 milestone May 14, 2024
@sosnovsky sosnovsky self-assigned this May 14, 2024
@sosnovsky sosnovsky mentioned this issue May 16, 2024
Merged
5 tasks
sosnovsky added a commit that referenced this issue May 16, 2024
@sosnovsky
#5715 Fix id token fetch for exception reports
5478cba
@sosnovsky sosnovsky mentioned this issue May 17, 2024
Merged
5 tasks
ioanmo226 pushed a commit that referenced this issue May 19, 2024
@sosnovsky
#5715 Fix id token fetch for exception reports (#5717)
fd04af8 
* #5715 Fix id token fetch for exception reports

* pr review
ioanmo226 pushed a commit that referenced this issue May 27, 2024
@sosnovsky @ioanmo226
#5715 Fix id token fetch for exception reports (#5717)
ef0e47e 
* #5715 Fix id token fetch for exception reports

* pr review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sosnovsky sosnovsky

Labels
actionable
Projects
None yet
Milestone
8.5.5: Manifest V3
Development

Successfully merging a pull request may close this issue.

#5715 Fix id token fetch for exception reports FlowCrypt/flowcrypt-browser
1 participant
@sosnovsky