Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 917 day night theme #1891

Merged
merged 31 commits into from
Jul 6, 2022
Merged

Issue 917 day night theme #1891

merged 31 commits into from
Jul 6, 2022

Conversation

DenBond7
Copy link
Collaborator

@DenBond7 DenBond7 commented Jul 5, 2022

This PR added day/hight support

close #917

Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities

DenBond7 added 30 commits June 24, 2022 16:02
@DenBond7
Switched to use Material Design Theme.| #1870
53de0a2
@DenBond7
Refactored code.| #1870
a22a086
@DenBond7
Fixed appBarLayout color.| #1870
991027d
@DenBond7
Added some style changes. Refactored code.| #1870
cbdf80d
@DenBond7
Modified FloatingActionButton style.| #1870
3de3ab3
@DenBond7
Modified buttons style.| #1870
fbcfe5c
@DenBond7
Fixed toolbar size.| #1870
bb674db
@DenBond7
Fixed some UI.| #1870
83aee15
@DenBond7
Fixed NavigationView style.| #1870
c25d5b4
@DenBond7
Set Theme.Material3.Light as a default theme.| #1870
fa474e5
@DenBond7
Fixed nav header style.| #1870
ff70320
@DenBond7
Fixed progress bar style.| #1870
92bd6b4
@DenBond7
Fixed fragment_create_message.| #1870
3ed7749
@DenBond7
Fixed the last commit.| #1870
bb4a237
@DenBond7
Removed unused resources.| #1870
87b6bf0
@DenBond7
Switched to use Theme.Material3.DayNight. Fixed use the dark theme in…
d5b28dc 
… WebView.| #1870
@DenBond7
Fixed issue with some buttons background.| #1870
2d824cf
@DenBond7
Merge remote-tracking branch 'origin/issue_1870_migrate_to_material_d…
de23b27 
…esign' into issue_917_day_night_theme
@DenBond7
Fixed DayNight for WebView. Added WebViewExt.kt| #917
6084e5b
@DenBond7
Added using colorSurface for some views.| #917
cf14183
@DenBond7
Merge branch 'master' into issue_917_day_night_theme
2ff1b68 
# Conflicts:
#	FlowCrypt/build.gradle
#	FlowCrypt/src/main/res/values/themes.xml
@DenBond7
Fixed issues after merge.| #917
78fdde7
@DenBond7
Fixed UI for some views.| #917
311bf70
@DenBond7
Merge branch 'master' into issue_917_day_night_theme
d95d420
@DenBond7
Fixed UI for some views. Step 2.| #917
ff16ee1
@DenBond7
Fixed UI for some views. Step 3.| #917
10a9d2b
@DenBond7
Removed redundant code.| #917
d081210
@DenBond7
Refactored code.| #917
a55be06
@DenBond7
Fixed a background color in EmailWebView.| #917
18c35e4
@DenBond7
Removed unused resources.| #917
fa0091d
@DenBond7 DenBond7 added this to the 1.3.5: Revoked keys milestone Jul 5, 2022
@DenBond7
Copy link
Collaborator Author

DenBond7 commented Jul 5, 2022

<!--<item name="elevationOverlayEnabled">false</item>-->

@DenBond7 DenBond7 marked this pull request as ready for review July 6, 2022 09:06
@DenBond7 DenBond7 requested a review from IvanPizhenko as a code owner July 6, 2022 09:06
@DenBond7 DenBond7 mentioned this pull request Jul 6, 2022
Closed
@DenBond7 DenBond7 linked an issue Jul 6, 2022 that may be closed by this pull request
dark theme option for evening work #448
Closed
@IvanPizhenko IvanPizhenko merged commit 916f5fa into master Jul 6, 2022
@IvanPizhenko IvanPizhenko deleted the issue_917_day_night_theme branch July 6, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanPizhenko IvanPizhenko IvanPizhenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.5: Revoked keys
Development

Successfully merging this pull request may close these issues.

Migrate to use Theme.MaterialComponents.DayNight as a base theme dark theme option for evening work
2 participants
@DenBond7 @IvanPizhenko