Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1251 pass in ram decrypt msg #1282

Merged
merged 13 commits into from
Jun 9, 2021
Merged

Conversation

DenBond7
Copy link
Collaborator

@DenBond7 DenBond7 commented Jun 8, 2021

This PR added handling passphrase in memory when we decrypt a message

close #1251 // if this PR closes an issue


Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities

@DenBond7 DenBond7 added the PR submitted PR is submitted for this issue label Jun 8, 2021
@DenBond7 DenBond7 added this to the 1.1.9 milestone Jun 8, 2021
@DenBond7 DenBond7 marked this pull request as ready for review June 8, 2021 08:19
@DenBond7 DenBond7 requested a review from tomholub June 8, 2021 08:19
Copy link
Contributor

@seisvelas seisvelas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests and code look good, I can't find any problems.

@DenBond7
Copy link
Collaborator Author

DenBond7 commented Jun 9, 2021

@tomholub I can already merge it. Please let me know if you would like to review it.

@tomholub
Copy link
Collaborator

tomholub commented Jun 9, 2021

I can review after

@tomholub tomholub merged commit 41261ec into master Jun 9, 2021
@tomholub tomholub deleted the issue_1251_pass_in_ram_decrypt_msg branch June 9, 2021 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR submitted PR is submitted for this issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass phrase in memory. Decrypt a message
3 participants