Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made PgpKeyDetails.lastModified as nullable. Refactored code.| #1260 #1261

Merged
merged 1 commit into from
May 28, 2021
Merged

Made PgpKeyDetails.lastModified as nullable. Refactored code.| #1260 #1261

merged 1 commit into from
May 28, 2021

Conversation

DenBond7
Copy link
Collaborator

This PR made PgpKeyDetails.lastModified as nullable to prevent NPE

close #1260 // if this PR closes an issue

Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities

@DenBond7 DenBond7 added the PR submitted PR is submitted for this issue label May 27, 2021
@DenBond7 DenBond7 added this to the 1.1.9 milestone May 27, 2021
@DenBond7 DenBond7 merged commit 829e099 into master May 28, 2021
@DenBond7 DenBond7 deleted the issue_1260_fix_npe_in_pgpkeydetails branch May 28, 2021 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seisvelas seisvelas seisvelas approved these changes

@IvanPizhenko IvanPizhenko Awaiting requested review from IvanPizhenko

Assignees
No one assigned
Labels
PR submitted PR is submitted for this issue
Projects
None yet
Milestone
1.1.9
Development

Successfully merging this pull request may close these issues.

NPE in KeyRingInfo.getLastModified()
2 participants
@DenBond7 @seisvelas