Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable password-protected messages if FES is not used #1621

Closed
Tracked by #1545
DenBond7 opened this issue Dec 21, 2021 · 3 comments · Fixed by #1660
Closed
Tracked by #1545

disable password-protected messages if FES is not used #1621

DenBond7 opened this issue Dec 21, 2021 · 3 comments · Fixed by #1660
Assignees

Comments

@DenBond7
Copy link
Collaborator

No description provided.

@tomholub
Copy link
Collaborator

As mentioned in #1620 (comment) , we will be merging the functionality in bits an pieces and it will only be enabled for senders on flowcrypt.com domain where we know that FES is running.

Once it's all done and tested and merged, this will be the last issue to do: remove the flowcrypt.com sender restriction, and instead allow the functionality when the user has FES running, otherwise disable it.

On browser extension, during initial setup and when re-fetching client configuration, we store a boolean in local storage, for that user account, to indicate if FES is available. If it is, we never try to get client configuration from flowcrypt.com/api anymore - we always get it from FES going forward.

This boolean is also used when deciding if password protected messages are available.

@DenBond7
Copy link
Collaborator Author

@tomholub I'd like to clarify one moment. When do we know that we use FES? When do we have a successful response for "https://fes.{domain}/api/"? like

{
   "vendor":"FlowCrypt",
   "service":"enterprise-server",
   "orgId":"flowcrypt.com",
   "version":"2022-03",
   "endUserApiVersion":"v1",
   "adminApiVersion":"v1"
}

Or should I check some value in this response?

@tomholub
Copy link
Collaborator

tomholub commented Jan 24, 2022

Here #1202 (comment)

https://fes.{domain}/api/ has to return status 200 that includes service that equals enterprise-server.

DenBond7 added a commit that referenced this issue Jan 24, 2022
IvanPizhenko pushed a commit that referenced this issue Jan 24, 2022
…1660)

* Disabled password-protected messages for accounts if FES is not used. Refactored code.| #1621

* Fixed and updated tests.| #1621
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants