Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app crash by importing a private key without an email address #1570

Closed
martgil opened this issue Nov 22, 2021 · 1 comment · Fixed by #1523
Closed

app crash by importing a private key without an email address #1570

martgil opened this issue Nov 22, 2021 · 1 comment · Fixed by #1523
Assignees
Labels

Comments

@martgil
Copy link
Collaborator

martgil commented Nov 22, 2021

Description:
I have found an issue with the latest version of FlowCrypt app 1.2.4 that crashes the Keys view after importing a private key that doesn't contain an email.

Tested from an emulator and a real device.

Steps to reproduce:
crashed.asc.txt

  1. Download the crashed.asc.txt file (optional to rename if the app happens to unrecognized the file`
  2. Import the private key with the passphrase: passphrase
  3. The app will crash after the key is imported successfully.
  4. Open the FlowCrypt app once again and go to Keys and the app will crash once again.

Impact:
A user will no longer be able to access the Keys without even uninstalling the app.

@DenBond7
Copy link
Collaborator

#1523 will resolve this issue

tomholub pushed a commit that referenced this issue Nov 25, 2021
… keys per recipient (#1523)

* Added PublicKeyEntity. Refactored code. WIP.| #1188

* Fixed using ContactsDao.getAllContactsWithPgpLD().| #1188

* Fixed using ContactsDao.getAllContactsWithPgp()/getAllContactsWithPgpWhichMatched().| #1188

* Renamed ContactEntity to RecipientEntity.| #1188

* Renamed ContactsDao to RecipientDao.| #1188

* Refactored code.| #1188

* Renamed ContactsViewModel to RecipientsViewModel.| #1188

* Fixed a few methods in RecipientDao. Refactored code.| #1188

* Fixed RecipientDao.getRecipientByEmail().| #1188

* Fixed some moments with adding/updating a recipient with a pub key.| #1188

* Made a workable version after switching to use 'recipients' and 'pub_keys' tables.| #1188

* Fixed tests. Refactored code.| #1188

* Modified code to use a new logic to save contacts on the compose screen.| #1539

* Modified code to use a new logic to apply colors to recipients(chips).| #1540

* Added changes to use all recipient's pub keys for ecnryption + use all sender's mathing pub keys.| #1541

* Fixed signing option.| #1541

* Import recipients manually. Refactored code. Added LookUpPubKeysDialogFragment and ImportRecipientsFromSourceFragment..| #1542

* Added a base realization of importing pub keys manually.| #1542

* Added ImportAllPubKeysFromSourceDialogFragment.| #1542

* Removed unused source.| #1542

* Improved some classes.| #1566

* Added RecipientDetailsFragment.| #1566

* Fixed opening PublicKeyDetailsFragment. Refactored code.| #1566

* Fixed exporting pub key.| #1566

* Fixed deleting pub key.| #1566

* Fixed editing pub key.| #1566

* Fixed database migration bug.| #1188

* Fixed nav_graph.xml for test.| #1188

* Temporary disabled some tests.| #1188

* Temporary disabled some tests(step 2).| #1188

* Fixed Junit tests.| #1188

* Fixed some UI tests.| #1188

* Fixed merge conflicts.| #1188

* Fixed some PR comments. Refactored code.| #1188

* Fixed some PR comments. Refactored code. Step 2.| #1188

* Restored some code.| #1188

* Renamed a file.| #1188

* Fixed importing/updating pub keys for PublicKeyMsgBlock.| #1188
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants