implement disallow_attester_search_for_domains OrgRule

[tomholub]

part of #1298

including wildcard * support meaning don't search on attester at all

[tomholub]

Here is the implementation in OrgRules class:

https://github.com/FlowCrypt/flowcrypt-browser/blob/48cb02a244b71a2acffbbc0fdb6ed4254baa0da3/extension/js/common/org-rules.ts#L170-L192

Here is the implementation in public key lookup code - only affects lookup from Attester:

(search by email) https://github.com/FlowCrypt/flowcrypt-browser/blob/48cb02a244b71a2acffbbc0fdb6ed4254baa0da3/extension/js/common/api/key-server/attester.ts#L22-L28

(search by fingerprint) https://github.com/FlowCrypt/flowcrypt-browser/blob/48cb02a244b71a2acffbbc0fdb6ed4254baa0da3/extension/js/common/api/key-server/attester.ts#L38-L51

Right now, on Android, Attester is the only source of public keys. However, after #1201 , there will be two sources: WKD and Attester. This OrgRule here will only affects Attester, and will not affect WKD.

[DenBond7]

@tomholub Could you clarify what place should I change. As I understand, I should modify the logic on the following screen

[DenBond7]

It can be done after #1382 will be merged

[tomholub]

The behavior throughout the app needs to be modified. Any place that calls flowcrypt.com/attester. Instead of changing several places, you should just change the API client class instead.

On browser extension, we have a PubLookup class which will call Wkd class first, then Attester. Every time we need to look up public keys externally, we use the general PubLookup. Then the logic to skip Attester depending on the domain is there.

While this updates the behavior of the compose message view, the logic should be in the public key lookup classes themselves.

[DenBond7]

On browser extension, we have a PubLookup class which will call Wkd class first, then Attester. Every time we need to look up public keys externally, we use the general PubLookup. Then the logic to skip Attester depending on the domain is there.

I understand the described logic. I've alredy added support of disallow_attester_search_for_domains. But it looks a little different due to the existing approaches for Android and the app. In the Android app, the main point for API calls is FlowcryptApiRepository. Maybe when I will see the full logic with WKD I will try to make it looks closer to your realization.