Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CopyText keys to the open containing/target folders results in programs plugin #3167

Closed

Conversation

cibere
Copy link
Contributor

@cibere cibere commented Jan 4, 2025

This PR adds the CopyText key to the Open Containing Folder and Open Target Folder results that show up in the context menus generated by the programs plugin.

creating this as a draft PR so I can hopefully use appveyor to test it

Copy link

github-actions bot commented Jan 4, 2025

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ forbidden-pattern 22
❌ ignored-expect-variant 1
⚠️ non-alpha-in-dictionary 19

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@taooceros
Copy link
Member

@cibere is this ready for review?

@cibere
Copy link
Contributor Author

cibere commented Jan 8, 2025

@cibere is this ready for review?

No, it doesn't work for my and I can't figure out why, and i can't think of anything to try

@taooceros
Copy link
Member

I don't really remember but maybe ctrl+shift+c can copy the text instead of copying the underlying file? Actually I think automatically copying file makes the copytext somehow confusing

@cibere
Copy link
Contributor Author

cibere commented Jan 10, 2025

I don't really remember but maybe ctrl+shift+c can copy the text instead of copying the underlying file? Actually I think automatically copying file makes the copytext somehow confusing

yeah thats how it works. just doesn't do anything when i test it on the results from this PR

@cibere cibere closed this Jan 12, 2025
@cibere
Copy link
Contributor Author

cibere commented Jan 12, 2025

closing this for now, i might try and fix it later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants