Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a safety check for getproperty #2457

Merged
merged 1 commit into from
Feb 4, 2024
Merged

add a safety check for getproperty #2457

merged 1 commit into from
Feb 4, 2024

Conversation

taooceros
Copy link
Member

add a safety check for #2395 (comment)

This seems to be the only place that we didn't check whether property exists.

Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (1)

getproperty

To accept these unrecognized words as correct, you could run the following commands

... in a clone of the [email protected]:Flow-Launcher/Flow.Launcher.git repository
on the browserbookmark-fix branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/prerelease/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/7244487280/attempts/1'

OR

To have the bot accept them for you, reply quoting the following line:
@check-spelling-bot apply updates.

Warnings (1)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

ℹ️ Warnings Count
ℹ️ non-alpha-in-dictionary 10

See ℹ️ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@@ -2,12 +2,14 @@
using System.Collections.Generic;
using System.IO;
using System.Text.Json;
using Flow.Launcher.Infrastructure.Logger;
Copy link
Member

@jjw24 jjw24 Dec 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Infrastructure Logger, are we still referencing the infra project for logging?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh mb forget about this is for plugin. Though I think somewhere else is still using Infra? I will check soon

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we ref Infra for Enum displaying...Unless we want to get rid of that it seems to ok to ref the static Log?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm actually used for calling logging, when we redo logging we can move it to Plugin project so there is less/no dependency on the Infrastructure project.

@jjw24 jjw24 added the bug Something isn't working label Dec 18, 2023
@jjw24 jjw24 added this to the 1.17.0 milestone Dec 18, 2023
@jjw24 jjw24 merged commit 15dc94b into dev Feb 4, 2024
2 checks passed
@jjw24 jjw24 deleted the browserbookmark-fix branch February 4, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants