Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ConcurrentDictionary for JsonRPC Settings #2428

Merged
merged 1 commit into from
Nov 19, 2023
Merged

Conversation

taooceros
Copy link
Member

@taooceros taooceros commented Nov 18, 2023

There is some potential of data race between queries.

@taooceros taooceros added the bug Something isn't working label Nov 18, 2023
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (2)

hyperlink
linkbtn

To accept these unrecognized words as correct, you could run the following commands

... in a clone of the [email protected]:Flow-Launcher/Flow.Launcher.git repository
on the concurrent-setting-jsonrpc branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.22/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/6916101501/attempts/1'

OR

To have the bot accept them for you, reply quoting the following line:
@check-spelling-bot apply updates.

Errors (3)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ ignored-expect-variant 6
ℹ️ no-newline-at-eof 1
ℹ️ non-alpha-in-dictionary 9

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@taooceros taooceros requested a review from jjw24 November 18, 2023 23:40
@jjw24 jjw24 added this to the 1.17.0 milestone Nov 19, 2023
@jjw24 jjw24 merged commit b3cb0fe into dev Nov 19, 2023
2 checks passed
@jjw24 jjw24 deleted the concurrent-setting-jsonrpc branch November 19, 2023 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants