Delay restart after installing/uninstalling/updating plugins #2369

VictoriousRaptor · 2023-09-29T05:57:49Z

Feature

Delay restart after installing/uninstalling/updating plugins.

Changes

Core

Move Install/Uninstall plugin logic to Core.PluginManager
Disallow modifying a plugin twice in a session.

Plugins Manger

New option for Plugins Manger: AutoRestartAfterChanging. Default is false. (Should we set to true to keep current behavior?)
Exclude installed plugins from pm install
Exclude modified(i.e. updated/installed/uninstalled in this session) plugins from pm install and pm update results
Show plugin remote icons in pm Install results.
Add glyphs for pm context menu
Reduce messageboxes to improve consistency
Fix BUG: Downloading plugins makes error when original zip file existing #2419

Tests:

Different message boxes and notification are shown when AutoRestartAfterChanging == false.
plugins can be installed/uninstalled after restart
Uninstall a plugin, then install again before restarting not allowed.
Installing twice before restarting not allowed.
Existing zip deleted when downloading zip.

- Option and UI - New prompts and notification messages

VictoriousRaptor · 2023-10-06T08:29:54Z

Plugins/Flow.Launcher.Plugin.PluginsManager/PluginsManager.cs

@@ -136,13 +146,11 @@ internal async Task InstallOrUpdateAsync(UserPlugin plugin)
            {
                await Http.DownloadAsync(plugin.UrlDownload, filePath).ConfigureAwait(false);

-                Context.API.ShowMsg(Context.API.GetTranslation("plugin_pluginsmanager_downloading_plugin"),
-                     string.Format(Context.API.GetTranslation("plugin_pluginsmanager_download_success"), plugin.Name));
-


Download success notification removed.

VictoriousRaptor · 2023-10-13T02:55:13Z

Oh no looks like spell check is really broken...

jjw24 · 2023-10-14T07:11:08Z

We will need to handle an obscure scenario where user chooses to do manual restart, install a plugin and then for some reason uninstalls the same plugin, this will freak flow out a little. Same thing but for vice versa will also happen- uninstall and install the same plugin.

Plugins/Flow.Launcher.Plugin.PluginsManager/Languages/en.xaml

jjw24 · 2023-10-14T07:18:08Z

Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs

@@ -107,15 +107,15 @@ public interface IPublicAPI
        /// </summary>
        /// <param name="title">Message title</param>
        /// <param name="subTitle">Message subtitle</param>
-        /// <param name="iconPath">Message icon path (relative path to your plugin folder)</param>
+        /// <param name="iconPath">Full path to icon</param>


Is this comment change correct? Is it relative or full path? I thought it's still some like ./img/icon.png?

It's the full path.

relative path also works

relative path also works

Are you sure? iirc I changed this line cuz I found a Python plugin had no icon. maybe it's a Python side issue?

Flow.Launcher/Flow.Launcher.Plugin/Result.cs

Lines 63 to 81 in 026e5f5

public string IcoPath

{

get { return _icoPath; }

set

{

// As a standard this property will handle prepping and converting to absolute local path for icon image processing

if (!string.IsNullOrEmpty(value)

&& !string.IsNullOrEmpty(PluginDirectory)

&& !Path.IsPathRooted(value)

&& !value.StartsWith("http://", StringComparison.OrdinalIgnoreCase)

&& !value.StartsWith("https://", StringComparison.OrdinalIgnoreCase))

{

_icoPath = Path.Combine(PluginDirectory, value);

}

else

{

_icoPath = value;

}

}

Maybe the json parser doesn't abide this setter?

jjw24 · 2023-10-15T03:22:08Z

We will need to handle an obscure scenario where user chooses to do manual restart, install a plugin and then for some reason uninstalls the same plugin, this will freak flow out a little. Same thing but for vice versa will also happen- uninstall and install the same plugin.

Best I can think of that is easy to solve is persisting three type of lists installed/uninstalled/updated in memory and each action should check against this list first.

Co-authored-by: Jeremy Wu <[email protected]>

This reverts commit 0c8729f.

VictoriousRaptor · 2023-11-08T16:01:37Z

We will need to handle an obscure scenario where user chooses to do manual restart, install a plugin and then for some reason uninstalls the same plugin, this will freak flow out a little. Same thing but for vice versa will also happen- uninstall and install the same plugin.

Best I can think of that is easy to solve is persisting three type of lists installed/uninstalled/updated in memory and each action should check against this list first.

You can't uninstall right after installing since the installed plugin is not added to list yet. Installing after uninstalling throws exception though.

- Download zip to temp folder - Unzip to unique folder

jjw24 · 2023-11-12T03:48:22Z

hey @VictoriousRaptor looks like you added merging the plugins manager functionality to this PR, is it possible to branch this change out so this PR is just for the delay restart ?

jjw24

👍

VictoriousRaptor added 3 commits September 28, 2023 23:45

Remove download success notification

31131ea

Add AutoRestartAfterChanging option

1334798

- Option and UI - New prompts and notification messages

Fix wrong doc

0c8729f

VictoriousRaptor commented Oct 6, 2023

View reviewed changes

VictoriousRaptor marked this pull request as ready for review October 6, 2023 08:30

VictoriousRaptor requested review from taooceros, jjw24, Garulf, JohnTheGr8 and deefrawley and removed request for taooceros October 6, 2023 08:34

VictoriousRaptor self-assigned this Oct 6, 2023

VictoriousRaptor added this to the 1.17.0 milestone Oct 6, 2023

VictoriousRaptor added enhancement New feature or request kind/ux related to user experience labels Oct 6, 2023

VictoriousRaptor and others added 2 commits October 6, 2023 16:35

Merge branch 'dev' into delay-restart-2

117ef26

Merge branch 'dev' into delay-restart-2

9d0ff71

jjw24 added the review in progress Indicates that a review is in progress for this PR label Oct 12, 2023

Merge branch 'dev' into delay-restart-2

dd6a276

jjw24 reviewed Oct 14, 2023

View reviewed changes

Plugins/Flow.Launcher.Plugin.PluginsManager/Languages/en.xaml Outdated Show resolved Hide resolved

jjw24 reviewed Oct 14, 2023

View reviewed changes

Plugins/Flow.Launcher.Plugin.PluginsManager/Languages/en.xaml Outdated Show resolved Hide resolved

jjw24 reviewed Oct 14, 2023

View reviewed changes

Plugins/Flow.Launcher.Plugin.PluginsManager/Languages/en.xaml Outdated Show resolved Hide resolved

jjw24 reviewed Oct 14, 2023

View reviewed changes

jjw24 mentioned this pull request Nov 7, 2023

feat: Update all plugins result #2412

Merged

3 tasks

VictoriousRaptor and others added 2 commits November 8, 2023 21:51

Tweak notification text

72134e8

Co-authored-by: Jeremy Wu <[email protected]>

Revert "Fix wrong doc"

0870c5a

This reverts commit 0c8729f.

VictoriousRaptor added 12 commits November 11, 2023 00:06

Use toast to improve consistency

08da4e3

Move Install/Uninstall plugin logic to Core.PluginManager

e7ffd57

Exclude installed plugins in pm install results

5b2220b

Show plugin icons in pm Install results

842451d

Add glyphs for pm context menu

4172115

Fix typo

54e255c

Make settings field private

bf59888

Throw exception when zip not found

b7a7836

Check if plugin has been modified when installing/updating/uninstalling

69dad1b

Remove unused import

53eec76

Hide modified plugins in query results

50449de

Refactor plugin zip logic

f6a4942

- Download zip to temp folder - Unzip to unique folder

VictoriousRaptor added the Code Refactor label Nov 11, 2023

Remove comment

af9c662

VictoriousRaptor requested review from taooceros and jjw24 November 11, 2023 08:41

Delete existing zip before downloading

c18ae41

VictoriousRaptor added the bug Something isn't working label Nov 12, 2023

jjw24 approved these changes Nov 19, 2023

View reviewed changes

jjw24 removed bug Something isn't working review in progress Indicates that a review is in progress for this PR labels Nov 19, 2023

jjw24 merged commit 4efac50 into Flow-Launcher:dev Nov 19, 2023

VictoriousRaptor deleted the delay-restart-2 branch November 19, 2023 06:13

VictoriousRaptor added the bug Something isn't working label Nov 20, 2023

VictoriousRaptor mentioned this pull request Dec 23, 2023

Plugin fails to install if already downloaded #975

Closed

jjw24 removed the bug Something isn't working label Feb 4, 2024

jjw24 mentioned this pull request Feb 4, 2024

Release 1.17.0 | Plugin 4.2.0 #2452

Merged

VictoriousRaptor mentioned this pull request Feb 12, 2024

Install plugins directly from the Plugin Store #2094

Open

jjw24 linked an issue Aug 17, 2024 that may be closed by this pull request

Delay restart after plugin install/uninstall #1685

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Delay restart after installing/uninstalling/updating plugins #2369

Delay restart after installing/uninstalling/updating plugins #2369

VictoriousRaptor commented Sep 29, 2023 •

edited

Loading

VictoriousRaptor Oct 6, 2023

VictoriousRaptor commented Oct 13, 2023

jjw24 commented Oct 14, 2023 •

edited

Loading

jjw24 Oct 14, 2023

VictoriousRaptor Oct 14, 2023

taooceros Oct 21, 2023

VictoriousRaptor Oct 22, 2023

taooceros Oct 25, 2023

jjw24 commented Oct 15, 2023

VictoriousRaptor commented Nov 8, 2023

jjw24 commented Nov 12, 2023

jjw24 left a comment

	public string IcoPath
	{
	get { return _icoPath; }
	set
	{
	// As a standard this property will handle prepping and converting to absolute local path for icon image processing
	if (!string.IsNullOrEmpty(value)
	&& !string.IsNullOrEmpty(PluginDirectory)
	&& !Path.IsPathRooted(value)
	&& !value.StartsWith("http://", StringComparison.OrdinalIgnoreCase)
	&& !value.StartsWith("https://", StringComparison.OrdinalIgnoreCase))
	{
	_icoPath = Path.Combine(PluginDirectory, value);
	}
	else
	{
	_icoPath = value;
	}
	}

Delay restart after installing/uninstalling/updating plugins #2369

Delay restart after installing/uninstalling/updating plugins #2369

Conversation

VictoriousRaptor commented Sep 29, 2023 • edited Loading

Feature

Changes

Core

Plugins Manger

Tests:

VictoriousRaptor Oct 6, 2023

Choose a reason for hiding this comment

VictoriousRaptor commented Oct 13, 2023

jjw24 commented Oct 14, 2023 • edited Loading

jjw24 Oct 14, 2023

Choose a reason for hiding this comment

VictoriousRaptor Oct 14, 2023

Choose a reason for hiding this comment

taooceros Oct 21, 2023

Choose a reason for hiding this comment

VictoriousRaptor Oct 22, 2023

Choose a reason for hiding this comment

taooceros Oct 25, 2023

Choose a reason for hiding this comment

jjw24 commented Oct 15, 2023

VictoriousRaptor commented Nov 8, 2023

jjw24 commented Nov 12, 2023

jjw24 left a comment

Choose a reason for hiding this comment

VictoriousRaptor commented Sep 29, 2023 •

edited

Loading

jjw24 commented Oct 14, 2023 •

edited

Loading